Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't successfully rerun the cookbook if set the wrong parameter the first time #201

Closed
lanqisong opened this issue Jan 16, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@lanqisong
Copy link

commented Jan 16, 2015

If the first time I set the wrong parameter e.g node['rabbitmq']['address'] , the cookbook exited when restarting the rabbitmq.
Then second time I corrected the node['rabbitmq']['address'], and rerun the recipe, it will exited before the reconfigure the rabbitmq-env.conf file. Because the recipe will try to start the rabbtimq before reconfigure at this line: https://github.com/jjasghar/rabbitmq/blob/master/recipes/default.rb#L115-L117

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2015

It looks like we repeat that line per the case statement. It'll probably be a good idea to pull it out and put it at the bottom of the recipe.

I'll put together a PR today of what i'm suggesting, and maybe you could test it?

jjasghar pushed a commit that referenced this issue Jan 16, 2015

JJ Asghar
Pushed the service enable and start to bottom
- Moved the service enable and start to the bottom of the default
recipe so you can change variables around.
- This should resolve #201
@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2015

#202, @lanqisong can you test please?

@lanqisong

This comment has been minimized.

Copy link
Author

commented Jan 17, 2015

@jjasghar I have tested the patch, look good to me, I think you could merge it to the master branch, thanks!

jjasghar pushed a commit that referenced this issue Jan 20, 2015

JJ Asghar
Pushed the service enable and start to bottom
- Moved the service enable and start to the bottom of the default
recipe so you can change variables around.
- This should resolve #201

jjasghar pushed a commit that referenced this issue Jan 28, 2015

JJ Asghar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.