Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version pining does not work by default with use_distro_version #210

Closed
kramvan1 opened this issue Jan 26, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@kramvan1
Copy link
Contributor

commented Jan 26, 2015

There are two attributes used when trying to install the rabbitmq package from the default disto repo:
use_distro_version which defaults to False, and version which defaults to 3.4.3.

if node['rabbitmq']['use_distro_version']
package 'rabbitmq-server' do
action :install
version node['rabbitmq']['version']
end

When setting the use_distro_version to true, it will most likely always fail since the version 3.4.3 is not usually available in the distro repo's yet. So, that means to have to specific the version attribute and are forced into pinning down your distro version. I think that's the opposite of what most folks want here when using the default distro version.

I would like to propose two choices here

A. Simple remove the version attribute from the distro package install resource. That would line up better with how most other cookbook are done.

B. Add another flag to make the pinning of the distro version optional, like:
if node['rabbitmq']['use_distro_version']
package 'rabbitmq-server' do
action :install
version node['rabbitmq']['version'] if node['rabbitmq']['pin_distro_version']
end

Opinions on which approach to take here?

@smurawski

This comment has been minimized.

Copy link

commented Jan 26, 2015

@jjasghar Any thoughts? @kramvan1 came in to office hours and I liked option 2. He's going to create a PR on that.

@kramvan1

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2015

#211 Created this PR for option B.

@jjasghar jjasghar closed this Feb 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.