Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate attributes ['cluster_disk_nodes'] vs ['clustering']['cluster_nodes'] #268

Closed
drazzib opened this issue May 15, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@drazzib
Copy link

commented May 15, 2015

Hi !

PR #238 introduced support for [:rabbitmq][:clustering][:cluster_nodes] attribute which is used in cluster LWRP and recipe.

But if you look at rabbitmq.config.erb template both old ['cluster_disk_nodes'] and ['clustering']['cluster_nodes'] attributes are used :

  {rabbit, [
<% if node['rabbitmq']['cluster'] && node['rabbitmq']['cluster_disk_nodes'] -%>
    <%if node['rabbitmq']['clustering']['use_auto_clustering']-%>
    {cluster_nodes, {[<%= node['rabbitmq']['clustering']['cluster_nodes'].map { |n| "'#{n['name']}'"}.join(',') %>], disc}},
    {cluster_partition_handling,<%= node['rabbitmq']['cluster_partition_handling'] %>},
    <% end %>
<% end %>

As is, it seems we need to provide values for both attibutes to generate a configuration with cluster_nodes value.

@drazzib

This comment has been minimized.

Copy link
Author

commented Mar 27, 2016

This issue has been fixed in PR #340

@drazzib drazzib closed this Mar 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.