Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "notifies restart" necessary for enabling or disabling a policy? #319

Closed
mlcooper opened this issue Oct 29, 2015 · 4 comments
Closed

Is "notifies restart" necessary for enabling or disabling a policy? #319

mlcooper opened this issue Oct 29, 2015 · 4 comments

Comments

@mlcooper
Copy link

@mlcooper mlcooper commented Oct 29, 2015

I am wondering if these two lines are necessary:
https://github.com/jjasghar/rabbitmq/blob/master/recipes/policy_management.rb#L31
https://github.com/jjasghar/rabbitmq/blob/master/recipes/policy_management.rb#L38

I can't find any documentation that says that the RabbitMQ service needs to be restarted to set or delete policies.

I can understand the need to do it for plugins and the management console, but the docs for creating a policy don't mention needing to restart the service.

Here's the article with rabbitmqctl set_policy documentation:
https://www.rabbitmq.com/man/rabbitmqctl.1.man.html

My concern is that in a running cluster, or if you have a single running RMQ server in production, the whole app needs to be restarted to work with policies which could cause some impact, but I'm not sure it's necessary to restart the app for policies.

@jjasghar jjasghar closed this Feb 2, 2016
@theundefined

This comment has been minimized.

Copy link

@theundefined theundefined commented Apr 20, 2017

Why that's issue is closed?
I think restart is unnecessary. Are there any cases when restart always "must be"? If yes - maybe it's good idea to allow parametrize it and disable for environments where restart is not needed?

@michaelklishin

This comment has been minimized.

Copy link
Member

@michaelklishin michaelklishin commented Apr 20, 2017

I can't comment on why the issue was closed but policy changes do not require a node restart, that's for sure.

As for 3.4.0 it is also unnecessary to restart when enabling or disabling plugins (at least those that ship with RabbitMQ, custom plugins can do all sorts of things).

@jjasghar do you recall the context of this?

@jjasghar

This comment has been minimized.

Copy link
Collaborator

@jjasghar jjasghar commented Apr 20, 2017

Honestly, nope. Normally I put a comment down or two, it seems I may have just gotten overly excited with close issue.

@jjasghar jjasghar reopened this Apr 20, 2017
@michaelklishin

This comment has been minimized.

Copy link
Member

@michaelklishin michaelklishin commented Feb 14, 2018

Addressed in dafeae5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.