Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erlang cookbook dependency is out of date #403

Closed
acholt opened this issue Dec 9, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@acholt
Copy link

commented Dec 9, 2016

Hi Guys

When using berks to install the rabbitmq cookbook it pulls the erlang cookbook version (1.3.2) and not latest which breaks. Should we not change the metadata to depends 'erlang' ~> 4.0.0?

Happy to do the PR if everyone is happy with that.

Cheers,
Andrew

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Dec 9, 2016

@acholt no objections from me. If you can include an Erlang cookbook change log with your PR, it would be easier to merge ;)

@michaelklishin michaelklishin changed the title Erlang dependency Erlang cookbook dependency is out of date Dec 9, 2016

@acholt

This comment has been minimized.

Copy link
Author

commented Dec 11, 2016

Thanks @michaelklishin. I was looking at the history of metadata file and see the version lock was removed for rabbitmq in commit fixing for the tests by @jjasghar.

Pinning makes sense as it ensures it works on that version, unless there are other issues that I'm missing?

What is the stance in the community before I change it?

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Dec 11, 2016

Different RabbitMQ versions support different Erlang version ranges. My guess is that was the idea. Current dependency gives the user a lot of flexibility when it comes to Erlang version used: just specify it in your Berksfile. So with that I consider this resolved (or well, no longer relevant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.