Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookbook defaults broken with update to rabbitmq rpm names #416

Closed
mfischer90 opened this issue Mar 17, 2017 · 13 comments

Comments

Projects
None yet
3 participants
@mfischer90
Copy link

commented Mar 17, 2017

In the newer versions of rabbitmq, there are separate rmps for each OS version:

https://www.rabbitmq.com/releases/rabbitmq-server/v3.6.8/

The default for rpm is still:
default['rabbitmq']['rpm_package'] = "rabbitmq-server-#{node['rabbitmq']['version']}-1.noarch.rpm"

Which will no longer work since it needs to specify OS

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

This can be fixed by changing the rpm attribute, but defaults will no longer work

@mfischer90 mfischer90 changed the title cookbook broken with update to rabbitmq rpm names cookbook defaults broken with update to rabbitmq rpm names Mar 17, 2017

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2017

Can you put in a PR to fix this please?

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

I think we should do this: update the code that composes URLs to match the most recent release (well, the 3.6.6+ version with el6 and el7 packages) and then announce this on rabbitmq-users.

Arguably a way to override the entire URL may be a good idea for such cases.

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

If you look at the page it said it was updated today, and that's when the builds started breaking for me

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

@mfischer90 sorry but you may be misinterpreting the cause. There was a change earlier today which switched default client version to 3.6.8 (from pretty outdated 3.6.1): ce87ef8.

Since you are not clarifying what the change is exactly, I'm guessing it's due to the RPM package split into 2, one for CentOS 6 and one for CentOS 7. This happened in 3.6.6 last November (rabbitmq/rabbitmq-server#932), not in 3.6.8.

So either please be more specific about what the change is, or let's assume it's the package split that is unfortunate for this cookbook but is old news by now.

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

Not really related but potentially relevant: https://www.rabbitmq.com/releases/ may or may not be around in 6-12 months so it's a good idea to download RPMs from GitHub or Bintray.

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

Yes that is what I meant. So the default version was changed to a newer version, but the default rpm package is still:

default['rabbitmq']['rpm_package'] = "rabbitmq-server-#{node['rabbitmq']['version']}-1.noarch.rpm"

Since that rpm no longer exists in https://www.rabbitmq.com/releases(it was split like you said) the error occurs. So you probably want to change the default completely if /releases will be gone soon

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

3.6.1 still had the rpm that was not yet split

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

"rabbitmq-server-#{node['rabbitmq']['version']}-1.noarch.rpm" does not specify OS

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

You were right though, my initial cause was wrong. It was the version update today that broke this

@mfischer90

This comment has been minimized.

Copy link
Author

commented Mar 17, 2017

Updated OP to be correct

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2017

#418 I think resolves your issue.

@jjasghar jjasghar closed this Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.