Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are broken… #434

Closed
rmoriz opened this issue Apr 22, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@rmoriz
Copy link
Contributor

commented Apr 22, 2017

@rmoriz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2017

I have spent quite some time on the weekend and opened a couple of PRs. (#436, #437, #438).

There is still a lot of work todo because some tests don't actually do something. Especially the 'cluster' path is untested in Chefspec and in the test-cookbook and the real cookbook code looks scary/broken (that .to_json + a resource that requires a String as its name property).

Many recipes in the test-cookbook are untested as well. (iirc all except "default"). There are orphaned minitests left, too.

After fixing the Docker issue I've converted the serverspec tests to inspec and more tests are turning green now.

Still broken are old CentOS and Debian 7 because recent RabbitMQ versions need a newer Erlang…

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2017

this is amazing. thank you for this. 🥇 💯

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 24, 2017

@rmoriz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

Okay, there are plenty of issues/refactoring tasks left ;-)

I've just tried to fix the things that break the current CI setup.

Just a couple of notes:

Debian 7
The official RabbitMQ .deb seems to require the init-system-helpers package which is not available on Debian 7. I've changed the default to stick with the old RabbitMQ package from Debian 7, however LWRP-tests fail because the management interface does not work with it and the rabbitmqadmin script can't be downloaded. I've decativated the LWRP-kitchen for debian7 in the kitchen but IMHO you should consider sunsetting Debian 7 support at all.

CentOS 6

Some weird hostname error. The image defaults to "localhost.localdomain" and not a random hostname (which should be the default using docker and dokken) which forced me to this hack: ccc685e => When executed via "kitchen login ..." it works well, because HOSTNAME is set, however inspec fails…

ChefSpec
I've changed the default fauxhai/os version for redhat to '7.2'.

Travis
I configured the matrix so that each combo of OS x kitchen suite appears as a single element.

Let's see, if the PR is now green...

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 24, 2017

@rmoriz http://www.rabbitmq.com/install-debian.html explains how to install dependencies on older Debian and Ubuntu releases. init-system-helpers is available from the Debian Wheezy backports repository, for example.

@rmoriz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

@michaelklishin sure, but it was/is not implemented => new feature.
My motivation here was just to get CI working on CentOS and Ubuntu (well, I did a lot more but that was just goodwill) because the integration test-stack of acme-chef depends on it.

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 24, 2017

While I'm sure there's plenty of improvement, #438 makes 30 matrix rows pass. Wow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.