Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.erlang.cookie template is not marked as sensitive #465

Closed
smekalayahoo opened this issue Oct 18, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@smekalayahoo
Copy link
Contributor

commented Oct 18, 2017

The recipe doesnot mark the file as sensitive which logs the contents of the .erlang.cookie.

Since the .erlang.cookie is a secret shared by the nodes in a cluster, it should be marked as sensitive.

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

@smekalayahoo how do you suggest that the file is marked as sensitive? It has UNIX permissions of 0400. What is missing?

@smekalayahoo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2017

Right now, when we execute the recipe we find the .erlang.cookie value being logged in plain text.
The below PR should prevent the value from being logged in clear text.
#466

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

Ah, so it's a Chef's file resource property. Makes sense!

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

Thank you, #466 is in.

@smekalayahoo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2017

@michaelklishin Thanks, This was pretty fast

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

@jjasghar do you think we can roll out a patch release with this? :)

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2017

Yep!

I'll get it out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.