Cluster resource provider incorrectly determines node type?

[pauldmccann]

Hi,
I believe there is an error on line 259 of cluster.rb

currently it is using the following to determine what the cluster node type should be:
var_cluster_node_type = parse_cluster_nodes_string(new_resource.cluster_nodes).each { |node| node['name'] == var_node_name }.first['type'] # ~FC039

I believe it should be using .select. Right now, all nodes are using the nodetype of the first node in the list.
var_cluster_node_type = parse_cluster_nodes_string(new_resource.cluster_nodes).each { |node| node['name'] == var_node_name }.first['type'] # ~FC039

[michaelklishin]

Yes, the each seems suspicious. Note that all nodes cannot be RAM ones, so this issue may be deeper that it seems.

[michaelklishin]

@pauldmccann so it's in the cluster node type change action. Please submit a PR that corrects it. It should be a lower risk change than I expected at first.

[pauldmccann]

Thanks Michael. There should be a PR available now

…

On Fri, Feb 9, 2018 at 11:18 AM, Michael Klishin ***@***.***> wrote: @pauldmccann <https://github.com/pauldmccann> so it's in the cluster node type change action. Please submit a PR that corrects it. It should be a lower risk change than I expected at first. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#476 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOP-pAomrMtC8Oh6ZRQtKyBOByUAtaljks5tTG_YgaJpZM4SAEWw> .

[michaelklishin]

We believe #477 addressed this at least somewhat. The entire logic in that provider needs to be revisited.