Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COOK-4694 Remove service restart for vhost mgmnt #121

Merged
merged 1 commit into from Dec 9, 2014

Conversation

Projects
None yet
3 participants
@kamaradclimber
Copy link
Contributor

commented Jun 3, 2014

There is no need for such restart, the effect is immediate.

COOK-4694 Remove service restart for vhost mgmnt
There is no need for such restart, the effect is immediate
@korjjj

This comment has been minimized.

Copy link

commented Jul 25, 2014

Upvoting this.

@kamaradclimber

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2014

I think I need to sign the CLA again before the PR is considered

On Fri, Jul 25, 2014 at 6:49 AM, korjjj notifications@github.com wrote:

Upvoting this.


Reply to this email directly or view it on GitHub
#121 (comment).

Grégoire

@kamaradclimber

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2014

but it could be considered as an obvious fix (especially since I introduced
this restart a few months ago)

On Fri, Jul 25, 2014 at 12:19 PM, Grégoire Seux kamaradclimber@gmail.com
wrote:

I think I need to sign the CLA again before the PR is considered

On Fri, Jul 25, 2014 at 6:49 AM, korjjj notifications@github.com wrote:

Upvoting this.


Reply to this email directly or view it on GitHub
#121 (comment).

Grégoire

Grégoire

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Dec 7, 2014

Is this still relevant? If so I can merge this with another 👍 :)

@kamaradclimber

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2014

yes it is

jjasghar pushed a commit that referenced this pull request Dec 9, 2014

JJ Asghar
Merge pull request #121 from kamaradclimber/cook4694
COOK-4694 Remove service restart for vhost mgmnt

@jjasghar jjasghar merged commit a3540c0 into rabbitmq:master Dec 9, 2014

@kamaradclimber kamaradclimber deleted the kamaradclimber:cook4694 branch Dec 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.