Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user_has_tag? issue when name and tag are the same #140

Merged
merged 2 commits into from Jul 17, 2015

Conversation

Projects
None yet
3 participants
@shunwen
Copy link
Contributor

commented Sep 15, 2014

When passing a user with name "management" and tag "management", the tag won't be created because in user_has_tag? method the tag is considered to be existed. I think it'd be easier only run rabbitmqctl -q list_user management as command, and parse the result with ruby regex function like:

cmd.run_command
user_list = cmd.stdout # => "management\t[management test]"
tags = user_list.match(/^#{name}\s+\[(.+*)\]/)[1].split # => ["management", "test"]

@shunwen shunwen changed the title Fixed user_has_tag? issue when name and tag are the same Fix user_has_tag? issue when name and tag are the same Sep 15, 2014

@tas50

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2015

This bug is burning me right now with my monitoring user that needs the monitoring tag. It would be really great to get this merged and released.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2015

I'm planning on releasing another version of the rabbitmq cookbook this by end of week

@tas50

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2015

@jjasghar Any update on getting a release out with this fix?

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2015

Ideally in the next 24 hours. $DAYJOB resposibities have been taking priorities. But I blocked off my whole afternoon to get the released.

@jjasghar jjasghar merged commit 0578d2f into rabbitmq:master Jul 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.