Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make config file template source cookbook configurable #151

Merged
merged 1 commit into from Dec 9, 2014

Conversation

Projects
None yet
3 participants
@mgreensmith
Copy link
Contributor

commented Oct 17, 2014

Allows the wrapper cookbook author to provide the rabbitmq.config.erb in their wrapper cookbook. This is necessary if you want to eg. add configuration for plugins.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Nov 27, 2014

Interesting. I'm about to merge in some chefpsec tests, can you add one to cover this issue?

#168

@mgreensmith

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2014

Hmm, I'm not certain how we would test this action any deeper than via your proposed test in #168 (https://github.com/jjasghar/rabbitmq/pull/168/files#diff-b38757f597e170ce2c611c84c7737807R49). Changing the attribute ['rabbitmq']['config_template_cookbook'] should not result in a different converge behavior. Your proposed test for the rabbitmq.config.erb template will still apply against this resource even if the template has been sourced from an external cookbook.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Nov 30, 2014

Yeah chewing on this, i think your right, we don't have a way we can write a good spec around this. I'm open to suggestions here; hopefully someone will also chime in :)

@tas50

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2014

Just to chime in on the tests for this. Outside of using test kitchen with a mock wrapper cookbook there's not really a way to test this. The existing test process does ensure that adding this behavior doesn't break standard workflows though. I'm obviously biased since both @mgreensmith and I want this merged, but it's a fairly safe merge IMO.

@tas50

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2014

+1

jjasghar pushed a commit that referenced this pull request Dec 9, 2014

JJ Asghar
Merge pull request #151 from mgreensmith/master
make config file template source cookbook configurable

@jjasghar jjasghar merged commit 89ecfd4 into rabbitmq:master Dec 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.