Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chefspec update #168

Merged
merged 5 commits into from Dec 2, 2014

Conversation

@jjasghar
Copy link
Collaborator

commented Nov 27, 2014

This is an inital commit of some generic chefspec
tests for the rabbitmq cookbook. I've tied it up to
the rake travis task so when this is merged we can
have it run as part of the PR process.

Again this is just an example and a start, we can attempt
to test the LWRPs at a later date.

Comments are more than welcome.

JJ Asghar added 2 commits Nov 21, 2014
JJ Asghar
Chefspec is the best spec
This is an inital commit of some generic chefspec
tests for the rabbitmq cookbook. I've tied it up to
the `rake travis` task so when this is merged we can
have it run as part of the PR process.

Again this is just an example and a start, we can attempt
to test the LWRPs at a later date.

Comments are more than welcome.

let(:file_cache_path) { Chef::Config[:file_cache_path] }

version = '3.3.5'

This comment has been minimized.

Copy link
@jklare

jklare Nov 28, 2014

Contributor

maybe define this at the beginning and use it for node.default['rabbitmq']['version'] to avoid replicated definitions of the version (also this should probably be '3.3.5-1' ?)

end.converge(described_recipe)
end

let(:file_cache_path) { Chef::Config[:file_cache_path] }

This comment has been minimized.

Copy link
@jklare

jklare Nov 28, 2014

Contributor

this definition is not used at all (same for other specs)

JJ Asghar
Updated per @jklare suggestions
I attempted to get the version in object, but i couldn't seem to get it
correct. Any advice or suggestions are more than welcome.

I'd like to merge this ASAP so I can update to 3.4.2 this week.

describe 'rabbitmq::default' do

version = '3.3.5-1'

This comment has been minimized.

Copy link
@jjasghar

jjasghar Dec 1, 2014

Author Collaborator

I don't like this line.

ChefSpec::ServerRunner.new.converge(described_recipe)
end

let(:file_cache_path) { Chef::Config[:file_cache_path] }

This comment has been minimized.

Copy link
@michaelklishin

michaelklishin Dec 1, 2014

Member

Is this value actually used anywhere?

This comment has been minimized.

Copy link
@jjasghar

jjasghar Dec 1, 2014

Author Collaborator

In this spec specifically nope, but I had it there incase we'd need it in the future. I'm ok with removing it if you think it's a good idea.

This comment has been minimized.

Copy link
@michaelklishin

michaelklishin Dec 1, 2014

Member

I just wasn't sure why it is defined, not that it is a big deal to me.

jjasghar pushed a commit that referenced this pull request Dec 2, 2014
JJ Asghar

@jjasghar jjasghar merged commit 37e96d2 into master Dec 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jjasghar jjasghar removed the in progress label Dec 2, 2014

@jjasghar jjasghar deleted the chefspec_update branch Dec 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.