Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more chefspec tests #193

Merged
merged 1 commit into from Feb 3, 2015

Conversation

Projects
None yet
2 participants
@wenchma
Copy link
Contributor

commented Dec 30, 2014

Add some missing spec tests to cover more chef resources,
but it reports some same untouched resources repeatedly
for many times.

Fixes issue #190

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Dec 31, 2014

@wenchma it looks like we got some travis failures.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 2, 2015

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 8, 2015

@wenchma I tried fixing these errors, couldnt fix it :(.

Can you rip out those tests, so we can get this merged in?

@wenchma wenchma force-pushed the wenchma:issue#190 branch from af3787e to 23ec25b Jan 12, 2015

@wenchma

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2015

updated the PR for spec tests

@wenchma wenchma force-pushed the wenchma:issue#190 branch 3 times, most recently from 6beb17c to a15f343 Jan 12, 2015

@wenchma

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2015

~/rabbitmq$ rspec spec/
....................................

Finished in 1 minute 28.43 seconds (files took 4.51 seconds to load)
36 examples, 0 failures

ChefSpec Coverage report generated...

Total Resources: 23
Touched Resources: 23
Touch Coverage: 100.0%

You are awesome and so is your test coverage! Have a fantastic day!

@wenchma

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2015

@jjasghar success to run rspec on my local env, but the travis CI build failed, it confused me.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 13, 2015

Man, i try it on my local box, checking out your branch, and i get errors all over the place.

are you running this on a box with rabbitmq installed on it? I'm not and i'm seeing errors.

I'm gonna close the issue #190 so we have the conversation in one place.

@jjasghar jjasghar added Rebase labels Feb 2, 2015

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Feb 2, 2015

@wenchma can you rebase this guy and see if travis'll pass now? I think i've fixed things upstream.

@wenchma

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2015

@jjasghar Ok. I will rebase it and update the PR

@wenchma wenchma force-pushed the wenchma:issue#190 branch from a15f343 to 05b1780 Feb 3, 2015

@wenchma

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2015

have updated the PR, and the coverage result:
Finished in 1 minute 28.65 seconds (files took 4.43 seconds to load)
38 examples, 0 failures

ChefSpec Coverage report generated...

Total Resources: 23
Touched Resources: 23
Touch Coverage: 100.0%

You are awesome and so is your test coverage! Have a fantastic day!

@wenchma wenchma force-pushed the wenchma:issue#190 branch from 05b1780 to 6e45baf Feb 3, 2015

wenchma
Add more chefspec tests
Add some missing spec tests to cover more chef resources,
but it reports some same untouched resources repeatedly
for many times.

Fixes issue #190

@wenchma wenchma force-pushed the wenchma:issue#190 branch from 6e45baf to f311971 Feb 3, 2015

jjasghar pushed a commit that referenced this pull request Feb 3, 2015

JJ Asghar
Merge pull request #193 from wenchma/issue#190
Add more chefspec tests

@jjasghar jjasghar merged commit bfab274 into rabbitmq:master Feb 3, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.