New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #201 #202

Merged
merged 2 commits into from Jan 28, 2015

Conversation

Projects
None yet
2 participants
@jjasghar
Collaborator

jjasghar commented Jan 16, 2015

  • Moved the service enable and start to the bottom of the default recipe so you can change variables around.
  • This should resolve #201

@jjasghar jjasghar changed the title from Updated the RuboCop camel case to Fix for Issue #201 Jan 16, 2015

JJ Asghar added some commits Jan 16, 2015

JJ Asghar
Pushed the service enable and start to bottom
- Moved the service enable and start to the bottom of the default
recipe so you can change variables around.
- This should resolve #201
@@ -129,9 +125,6 @@ class Chef::Resource # rubocop:disable all
version node['rabbitmq']['version']
end
service node['rabbitmq']['service_name'] do
action [:enable, :start]

This comment has been minimized.

@wenchma

wenchma Jan 23, 2015

Contributor

other way, only to enable the service and not start the service, is it more reasonable? after configuring rabbit, it will be restart immediately now.
@jjasghar

@wenchma

wenchma Jan 23, 2015

Contributor

other way, only to enable the service and not start the service, is it more reasonable? after configuring rabbit, it will be restart immediately now.
@jjasghar

jjasghar pushed a commit that referenced this pull request Jan 28, 2015

@jjasghar jjasghar merged commit 2b1f6f2 into master Jan 28, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@jjasghar jjasghar removed the in progress label Jan 28, 2015

@jjasghar jjasghar deleted the rerun_issue201 branch Jan 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment