Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed regex behavior for guard command on set user permission resource #215

Merged
merged 3 commits into from Feb 5, 2015

Conversation

Projects
None yet
3 participants
@francoisnicholas
Copy link
Contributor

commented Feb 5, 2015

No description provided.

francoisnicholas added some commits Feb 5, 2015

changed regex to match /s instead /b
the default  vhost is a "/" which isn't a word and there's no word boundary to match on.
@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2015

Can you remove the metadata.rb change? Other than that this looks good. Just need another +1 on it.

@wfindley

This comment has been minimized.

Copy link

commented Feb 5, 2015

+1. What's wrong with the version bump in metadata?

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2015

I'm trying to control the version numbers, if everyone started doing it we'd have some crazy conflicts.

It happens in the Openstack repos with our CHANGLOG.md all the time.

@jjasghar jjasghar added TODO and removed Just need another +1 labels Feb 5, 2015

@jjasghar jjasghar added Ready To Merge and removed TODO labels Feb 5, 2015

jjasghar pushed a commit that referenced this pull request Feb 5, 2015

JJ Asghar
Merge pull request #215 from fnicholas/master
changed regex behavior for guard command on set user permission resource

@jjasghar jjasghar merged commit f96b884 into rabbitmq:master Feb 5, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.