Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
addition of attributes for downloading deb, rpm and esl-erlang-compat #220
I'll be glad to but I'm not quite sure how to add more to the spec tests than is provided, both rabbitmq deb and rpm files already have checks for availability in the cache path and checks for installation.
It seems there are already specs to test we are getting the appropriate files :
If this PR passes tests, it means the new attributes are not breaking the expected/previous behaviour, but allow to change the source if you need to, which is good.
We could add some context in the specs changing the attributes and testing it's not using parameters for remote_files, but I'm not sure of the value to do so.
In addition in the specs we already use the version https://github.com/jjasghar/rabbitmq/blob/master/spec/default_spec.rb#L79. , so those new attribute are tested.
We really need this PR, because lately
ps : thanks for the Pr @dannietjoh
It's a really nice PR especially now when rabbitmq artifacts are non accessible on official site. Please read https://groups.google.com/forum/#!topic/rabbitmq-users/Ov0k_Xp0C3Y