Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more support for erlang args #247

Merged
merged 1 commit into from Apr 23, 2015

Conversation

Projects
None yet
4 participants
@kramvan1
Copy link
Contributor

commented Apr 7, 2015

No description provided.

@kramvan1

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2015

@cmluciano should be ready now, sorry for the CI churn

@cmluciano

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2015

Nice, can you squash your commits to one?

Add erl args
Add erl args and specs for them
@kramvan1

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2015

Squashed down to 1 commit, @cmluciano thx.

@cmluciano

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2015

LGTM @jjasghar

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 10, 2015

+1 👍

@kramvan1

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

@jjasghar Just a follow up that I would like to see this merged and a new version cut as it's critical to support advanced HA openstack environments.

jjasghar pushed a commit that referenced this pull request Apr 23, 2015

JJ Asghar

@jjasghar jjasghar merged commit d4678b2 into rabbitmq:master Apr 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.