Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ssl_ciphers #255

Merged
merged 1 commit into from Apr 23, 2015

Conversation

@kramvan1
Copy link
Contributor

kramvan1 commented Apr 21, 2015

Allow ssl ciphers to be configured

@kramvan1

This comment has been minimized.

Copy link
Contributor Author

kramvan1 commented Apr 21, 2015

@jjasghar This is another one we would like to get in this week, it's also just basic config options.

@kramvan1

This comment has been minimized.

Copy link
Contributor Author

kramvan1 commented Apr 22, 2015

@cmluciano @jjasghar Humm, seems travis failure is NOT related to this change, but rather to this one: #236 Looks like we pulled out the case to include the yum-epel and yum-erlang, but did not cleanup the specs or the metadata.

@cmluciano

This comment has been minimized.

Copy link
Collaborator

cmluciano commented Apr 22, 2015

Yes that was on purpose. The tests passes with my changes. The reason that they are failing now is due to the removal from the erlang package recipe change.

@kramvan1

This comment has been minimized.

Copy link
Contributor Author

kramvan1 commented Apr 22, 2015

@cmluciano thx for the update. I have removed those tests from the spec with my latest push.

@@ -56,6 +56,12 @@
:mode => 00644)
end

it 'allows ssl ciphers' do
node.set['rabbitmq']['ssl_ciphers'] = ['ecdhe_ecdsa,aes_128_cbc,sha256', 'ecdhe_ecdsa,aes_256_cbc,sha']
expect(chef_run).not_to render_file('/etc/rabbitmq/rabbitmq.config').with_content(

This comment has been minimized.

Copy link
@michaelklishin

michaelklishin Apr 22, 2015

Member

Is it just me or not_to should have been to here?

This comment has been minimized.

Copy link
@kramvan1

kramvan1 Apr 22, 2015

Author Contributor

yup, will clean that up and add in the default case of no specific ciphers.

Allow ssl ciphers to be configured
Also minor cleanup for spec with yum
jjasghar pushed a commit that referenced this pull request Apr 23, 2015
Added ssl_ciphers
@jjasghar jjasghar merged commit 09d2ec2 into rabbitmq:master Apr 23, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.