Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single quote and nil issues with cluster recipe #274

Merged
merged 5 commits into from Jun 16, 2015

Conversation

Projects
None yet
4 participants
@dude051
Copy link
Contributor

commented May 29, 2015

This builds on #267 to add:

  • More fixes to catch single quotes from cluster_status, current_cluster_node_type and node_name
    • Fixes from #267 the node_name still had single quotes which were removed on L113
    • The cluster_status, disc_nodes and ram_nodes functions passed back a match of ["rabbit@rabbit1'","'rabbit@rabbit2"] which contained single quotes from the middle of the match. This was removed L83, L91 and L100

In rare instances, if the cluster_status returns on a non running server or is not clustered yet, the matchers caused no matched and nil errors. Fixes were introduced to pass nil in some functions through and to better handle them specifically with cluster_join:

  • Passthrough of nil in some functions
  • Additional debug logging and handling of nil responses from functions
@dude051

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2015

To note, this is also duplicates in some ways of #263 and #273 but with additional changes and differences in the way nil was handled.

@dude051 dude051 changed the title Remove quote node name Fix single quote and nil issues with cluster recipe May 29, 2015

@XiangYao

This comment has been minimized.

Copy link

commented Jun 5, 2015

This looks great! Fixed multiple nil issues in this recipe!

jjasghar pushed a commit that referenced this pull request Jun 16, 2015

JJ Asghar
Merge pull request #274 from rackerlabs/remove-quote-node_name
Fix single quote and nil issues with cluster recipe

@jjasghar jjasghar merged commit a5f320c into rabbitmq:master Jun 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iramello

This comment has been minimized.

Copy link

commented on providers/cluster.rb in 01a4b9e Apr 4, 2016

This does not work in AWS Opsworks and Chef 11.10. Using select here works fine.

This comment has been minimized.

Copy link
Collaborator

replied Apr 4, 2016

I'm sorry but you'll have to fork this cookbook if you want to run chef 11 and ops works.

Please read the readme for what we officially support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.