Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gsub instead of gsub! #284

Merged
merged 1 commit into from Jul 17, 2015

Conversation

Projects
None yet
3 participants
@stevedomin
Copy link
Contributor

commented Jul 14, 2015

Currently some of the methods in the cluster provider are broken because they are using gsub! instead of gsub, as well as splitting on an array.

This PR fixes it by:

  • Using gsub instead of gsub!
  • Removing duplicate split
@alexpop

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2015

Fixes #282 and #285

@jjasghar jjasghar merged commit e6b29fe into rabbitmq:master Jul 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stevedomin stevedomin deleted the gocardless:steve-fix-cluster-provider branch Jul 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.