Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hardcoded --ram node type for cluster join #327

Merged
merged 2 commits into from Feb 2, 2016

Conversation

Projects
None yet
3 participants
@scalp42
Copy link
Contributor

commented Dec 16, 2015

cc @michaelklishin @jjasghar

Tested and working:

[2015-12-16T01:26:23+00:00] INFO: Processing rabbitmq_cluster[[{"name":"rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com","type":"disc"}]] action join (gz-rabbitmq::join line 5)
[2015-12-16T01:26:23+00:00] INFO: [rabbitmq_cluster] Action join ...
[2015-12-16T01:26:24+00:00] INFO: DOUDOU => rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com
[2015-12-16T01:26:25+00:00] INFO: [rabbitmq_cluster] Clustering node 'rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com' with 'rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com' ...

[2015-12-16T01:26:26+00:00] INFO: [rabbitmq_cluster] Node rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com joined in rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com with type disc
[2015-12-16T01:26:26+00:00] INFO: [{nodes,[{disc,['rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com','rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com']}]},{running_nodes,['rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com','rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com']},{cluster_name,<<"rabbit@ip-10-52-42-243.us-west-2.compute.internal">>},{partitions,[]}]

root@rabbitmq-i-fef72824 ~ # rabbitmqctl cluster_status
Cluster status of node 'rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com' ...
[{nodes,[{disc,['rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com',
                'rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com']}]},
 {running_nodes,['rabbit@ec2-54-201-251-170.us-west-2.compute.amazonaws.com',
                 'rabbit@ec2-54-200-235-67.us-west-2.compute.amazonaws.com']},
 {cluster_name,<<"rabbit@ip-10-52-42-243.us-west-2.compute.internal">>},
 {partitions,[]}]

@scalp42 scalp42 force-pushed the scalp42:node_type_fix branch from feb82f9 to 80f20c1 Dec 16, 2015

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Dec 16, 2015

Default node type should definitely not be RAM. There is no reason to use RAM nodes for 95% of the workloads.

@scalp42

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2015

Any chance we can merge it @michaelklishin ? The failing check is related to the if condition related to the node type passed.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Dec 16, 2015

@scalp42 I havent had a chance to look into this yet. It's on my TODO and when i have some time i'll be visiting this.

Though i do trust @michaelklishin's opinion ;)

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 10, 2016

Can you add a skip for the travis failure too?

@scalp42

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2016

@jjasghar passing now.

@scalp42

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2016

@michaelklishin @jjasghar we should really merge this in, this is literally hardcoded right now.

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2016

Yep!

I just need to set up another release. It takes a bit of time so I have to schedule it.

jjasghar pushed a commit that referenced this pull request Feb 2, 2016

JJ Asghar
Merge pull request #327 from scalp42/node_type_fix
fix hardcoded --ram node type for cluster join

@jjasghar jjasghar merged commit 199cdbb into rabbitmq:master Feb 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.