New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Rabbit on cluster join error, resolves #344 #346

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
3 participants
@CVTJNII
Contributor

CVTJNII commented Feb 19, 2016

This change uses a custom exception handler to throw errors in join_cluster(). A exception handler in action :join calls Chef::Application.fatal! to keep the same error functionality as before but an ensure block ensures Rabbit is always restarted. Resolves #344

I have not updated metadata as I'm assuming you want to manage that.

@scopenco

This comment has been minimized.

Show comment
Hide comment
@scopenco

scopenco May 10, 2016

+1 this patch fix problem with ':join', @jjasghar are you panning to merge it?
But for now i will use fork from @CVTJNII to deploy rabbitmq.

scopenco commented May 10, 2016

+1 this patch fix problem with ':join', @jjasghar are you panning to merge it?
But for now i will use fork from @CVTJNII to deploy rabbitmq.

@jjasghar

This comment has been minimized.

Show comment
Hide comment
@jjasghar

jjasghar May 10, 2016

Collaborator

Make it so.

Collaborator

jjasghar commented May 10, 2016

Make it so.

@jjasghar jjasghar merged commit 39c2cf4 into rabbitmq:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment