Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cipher examples #370

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@yoshiwaan
Copy link
Contributor

commented Jun 2, 2016

This PR matches the example ciphers in the attributes file to the current rspec tests.

4480a86 was a backwards compatibility breaking change for me. I'm not sure if it's the version of rabbit that I'm using, but the only valid configuration I get is when the openssl ciphers are double quoted (not single quoted) or the standard cipher strings are wrapped in curly braces. It was previously valid to just specify the cipher suite as an array of strings so long as they weren't in the Openssl format, now they must be an array of curly brace wrapped strings.

These examples would have made it a lot quicker to realise there was a change.

I would ask that you please increment the metadata version by a major version increment if backward compatibility breaking changes are introduced, so that the pessimistic matcher can work (i.e. depends 'rabbitmq', '~> 0.1')

Update examples
Updating examples of cipher suites to match rspec tests

@jjasghar jjasghar merged commit 80fc804 into rabbitmq:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.