Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attributes from the metadata #406

Merged
merged 2 commits into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@tas50
Copy link
Contributor

commented Jan 5, 2017

We don't use these anywhere and they're generally wrong

tas50 added some commits Jan 5, 2017

Remove attributes from the metadata
We don't use these anywhere and they're generally wrong

@jjasghar jjasghar merged commit 118be03 into rabbitmq:master Jan 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
:description => 'A list of lines to append to rabbitmq-env.conf for settings that may not yet be available with existing attributes',
:default => nil,
:type => 'array'
supports 'ubuntu', '>= 14.04'

This comment has been minimized.

Copy link
@devsibwarra

devsibwarra Jan 6, 2017

Contributor

Missing newline at EOF might make rubocop unhappy, unless you're ignoring that cop

This comment has been minimized.

Copy link
@jjasghar

jjasghar Jan 6, 2017

Collaborator

Good point, I'll make sure that 5.0.0 has rubocop happy before releasing it.

@tas50 tas50 deleted the tas50:patch-1 branch Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.