Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename params property to parameters #427

Merged

Conversation

Projects
None yet
4 participants
@shortdudey123
Copy link
Contributor

commented Apr 1, 2017

This cleans up the resource property errors.

Note: This is a breaking change

================================================================================
Recipe Compile Error in /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb
================================================================================
ArgumentError
-------------
Property `params` of resource `rabbitmq_parameter` overwrites an existing method.
Cookbook Trace:
---------------
  /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:28:in `class_from_file'
Relevant File Content:
----------------------
/opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:
 21:
 22:  actions :set, :clear, :list
 23:  default_action :set
 24:
 25:  attribute :parameter, :kind_of => String, :name_attribute => true
 26:  attribute :component, :kind_of => String
 27:  attribute :vhost, :kind_of => String
 28>> attribute :params, :kind_of => [Hash, Array], :default => {}
 29:
Platform:
---------
x86_64-linux
Rename params property to parameters
This cleans up the resource property errors.

Note: This is a breaking change

```
================================================================================
Recipe Compile Error in /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb
================================================================================
ArgumentError
-------------
Property `params` of resource `rabbitmq_parameter` overwrites an existing method.
Cookbook Trace:
---------------
  /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:28:in `class_from_file'
Relevant File Content:
----------------------
/opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:
 21:
 22:  actions :set, :clear, :list
 23:  default_action :set
 24:
 25:  attribute :parameter, :kind_of => String, :name_attribute => true
 26:  attribute :component, :kind_of => String
 27:  attribute :vhost, :kind_of => String
 28>> attribute :params, :kind_of => [Hash, Array], :default => {}
 29:
Platform:
---------
x86_64-linux
```
@shortdudey123

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2017

Note: TravisCI tests are still failing, however, they are due to other issues that are now being uncovered

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 1, 2017

Thank you. I guess it's time for a version bump.

@shortdudey123 shortdudey123 referenced this pull request Apr 1, 2017

Merged

Update kitchen dokken #428

@jjasghar jjasghar merged commit 99ccab4 into rabbitmq:master Apr 8, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@shortdudey123 shortdudey123 deleted the shortdudey123:fix_resource_property_override branch Apr 8, 2017

@erulabs

This comment has been minimized.

Copy link

commented Apr 12, 2017

@michaelklishin Any word on the version bump? This is the only cookbook blocking chef13 for the sensu cookbook which relies on this one in turn :)

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 12, 2017

@jjasghar can we release a 5.0 with this?

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2017

Will do

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 12, 2017

@jjasghar ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.