New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to default.rb library to handle frozen strings #430

Merged
merged 2 commits into from Apr 12, 2017
Jump to file or symbol
Failed to load files and symbols.
+2 −2
Diff settings

Always

Just for now

View
@@ -34,10 +34,10 @@ def format_kernel_parameters # rubocop:disable all
# theoretically opens the door for arbitrary kernel_app parameters to be
# declared.
kernel.select { |_k, v| !v.nil? }.each_pair do |param, val|
rendered << "{#{param}, #{val}}"
rendered << " {#{param}, #{val}}"
end
rendered.each { |r| r.prepend(' ') }.join(",\n")
rendered.each { |r| r }.join(",\n")

This comment has been minimized.

@devsibwarra

devsibwarra Apr 12, 2017

Contributor

Is there a reason to keep .each {} for this line or can it go away?

@devsibwarra

devsibwarra Apr 12, 2017

Contributor

Is there a reason to keep .each {} for this line or can it go away?

This comment has been minimized.

@michaelklishin

michaelklishin Apr 12, 2017

Member

Looks like it can go.

@michaelklishin

michaelklishin Apr 12, 2017

Member

Looks like it can go.

end
def format_ssl_versions
ProTip! Use n and p to navigate between commits in a pull request.