Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource cloning deprecation warnings #446

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
3 participants
@bdwyertech

This comment has been minimized.

Copy link
Contributor

commented May 15, 2017

👍

# Manual clustering
unless node['rabbitmq']['clustering']['use_auto_clustering']
# Join in cluster
rabbitmq_cluster cluster_nodes do
rabbitmq_cluster auto_cluster_nodes do

This comment has been minimized.

Copy link
@bdwyertech

bdwyertech May 15, 2017

Contributor

Maybe Instead of creating those two variables, create a unique name for the rabbitmq_cluster resource, e.g.

rabbitmq_cluster "Join Cluster (#{node['rabbitmq']['clustering']['cluster_name']})" do
  cluster_nodes cluster_nodes
  cluster_name node['rabbitmq']['clustering']['cluster_name']
  action :join
end
cluster_name node['rabbitmq']['clustering']['cluster_name']
action :join
end
end

# Set cluster name : It will be skipped once same cluster name has been set in the cluster.
rabbitmq_cluster cluster_nodes do
rabbitmq_cluster static_cluster_nodes do

This comment has been minimized.

Copy link
@bdwyertech

bdwyertech May 15, 2017

Contributor

Maybe something here like

rabbitmq_cluster "Configure Cluster (#{node['rabbitmq']['clustering']['cluster_name']})" do
  cluster_nodes cluster_nodes
  cluster_name node['rabbitmq']['clustering']['cluster_name']
  action [:set_cluster_name, :change_cluster_node_type]
end

@jjasghar jjasghar merged commit f16626a into rabbitmq:master Jun 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rdeusser rdeusser deleted the rdeusser:fix-deprecated-resource-cloning branch Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.