Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for adding retry to node start #454

Merged
merged 5 commits into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@amulyas
Copy link
Contributor

commented Aug 2, 2017

What we are noticing is that every time it get reconvered after the VM delete senario it failed once on second attempt it works so adding a retry to start the node, keeping values to defualt so no chang eofr anyone using cookbook but you can override defaults if you wanted to set to something else

@@ -252,6 +252,8 @@ class Chef::Resource

if node['rabbitmq']['manage_service']
service node['rabbitmq']['service_name'] do
retry node['rabbitmq']['retry']

This comment has been minimized.

Copy link
@michaelklishin

michaelklishin Aug 3, 2017

Member

According to Chef docs this should be retries.

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Aug 3, 2017

@jjasghar WDYT? With these defaults it seems reasonable to me, however, it turns out this is an attempt to solve #455 without understanding the root cause. So there is a better way but perhaps it would be a useful thing to have for some?

@amulyas amulyas closed this Sep 20, 2017

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

@jjasghar I still think that those two attributes would be useful to have. Any objections?

@michaelklishin michaelklishin merged commit e3ba5e7 into rabbitmq:master Sep 25, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.