Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify switchcase for rabbitmq plugins command #518

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@jklare
Copy link
Contributor

commented Mar 28, 2019

Proposed Changes

Use new method installed_rabbitmq_version to simplify switchcases
for plugins command.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

* use new method installed_rabbitmq_version to simplify switchcase
for plugins command
@michaelklishin michaelklishin merged commit 2c0b10b into rabbitmq:v5.x Mar 28, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@michaelklishin

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Thank you!

@chalb

This comment has been minimized.

Copy link

commented Apr 8, 2019

I really like this PR. Quick question: When will this be released?

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

No earlier than we have some feedback and decision made for #521.

@chalb

This comment has been minimized.

Copy link

commented Apr 9, 2019

Fair enough. Thank you for your advise!

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

So #521 is addressed as far as I'm concerned. I'd appreciate some sanity checking of the tip of the v5.x branch, then we can produce a new patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.