Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOK-3606] remove trailing \n from erlang cookie file contents #84

Merged
merged 2 commits into from Sep 21, 2013

Conversation

Projects
None yet
3 participants
@portertech
Copy link
Contributor

commented Sep 12, 2013

@sethvargo

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2013

@portertech do you think String#strip is more appropriate here, just in case there's extra spaces (that aren't newlines)?

@portertech

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2013

@sethvargo Updated to use strip(). It's unlikely that there will be extra spaces etc, but no reason to not cover our butts 👍

@portertech

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2013

@sethvargo 👍 ?

@sethvargo

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2013

👍

mattray added a commit that referenced this pull request Sep 21, 2013

Merge pull request #84 from portertech/COOK-3606
[COOK-3606] remove trailing \n from erlang cookie file contents

@mattray mattray merged commit 5015500 into rabbitmq:master Sep 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.