Skip isolating cover instructions when native coverage is available #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If OTP is compiled with native coverage support (OTP 27+ plus JIT), `cover` does not attempt to inject counters into the code, so isolating the cover instructions fails. We can skip that step when we detect native coverage support.
the-mikedavis
force-pushed
the
md-native-cover
branch
from
495ae55
to
0b6b816
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01%
==========================================
Files 3 3
Lines 932 933 +1
==========================================
+ Hits 802 803 +1
Misses 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OTP is compiled with native coverage support (OTP 27+ plus JIT),
coverdoes not attempt to inject counters into the code, so isolating the cover instructions fails. We can skip that step when we detect native coverage support.Connects #20