This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
amqp10_client_connection: Handle heartbeat in close_sent/2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message, sent by the timer module, may happen in the `close_sent`
state. We can ignore it but we still need to handle it.
I saw this case happen in CI:
*** System report during system_SUITE:init_per_group/2 for activemq 2020-02-12 06:06:06.473 ***
=WARNING REPORT==== 12-Feb-2020::06:06:06.473178 ===
terminating connection with reason '{function_clause,
[{amqp10_client_connection,close_sent,
[heartbeat,
{state,2,<0.455.0>,
(...)
michaelklishin
approved these changes
Feb 12, 2020
michaelklishin
added a commit
that referenced
this pull request
Feb 12, 2020
amqp10_client_connection: Handle heartbeat in close_sent/2 (cherry picked from commit b4d3ce7)
michaelklishin
added a commit
that referenced
this pull request
Apr 30, 2020
amqp10_client_connection: Handle heartbeat in close_sent/2 (cherry picked from commit b4d3ce7)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message, sent by the timer module, may happen in the
close_sentstate. We can ignore it but we still need to handle it.I saw this case happen in CI: