New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioned delivery tags, à la Bunny and Java client #200
Comments
Please post questions to rabbitmq-users or Stack Overflow. RabbitMQ uses GitHub issues for specific actionable items engineers can work on, not questions. Thank you. |
What you describe is known in other clients as versioned delivery tags. After connection recovery all channels are brand new and have delivery tag counter reset by RabbitMQ. This client does not support them but it should be fairly trivial to add because Java and Ruby clients do. |
Here's a commit that demonstrates how Bunny does it: ruby-amqp/bunny@21e39b9. |
@michaelklishin Thanks for the quick response. |
We were confused because the .NET documentation says the same thing: https://www.rabbitmq.com/dotnet-api-guide.html#connection-recovery
Emphasis mine. I had a look at the code, and I think I've discovered what's happening. The We're testing with the following change, and it appears to be working as expected: Entroper@f1d5bd1 |
@Entroper ah, perfect. Recovery in this client is a pretty faithful port of what we have in the Java client, so I expected that delivery tags should be versioned but looked at a couple of places where it wasn't obvious. Please submit a PR against the stable branch? |
@michaelklishin Will do. :) |
Fixed in #201. |
Thank you, we will QA it in the upcoming days. On Thu, Jun 9, 2016 at 11:22 PM, Entroper notifications@github.com wrote:
MK Staff Software Engineer, Pivotal/RabbitMQ |
ok apart from finding a bug related to BasicGet this should now be fixed in stable. |
Hi,
I am testing a recovery scenario by dropping the connection through management console. Below is my scenario.
AutomaticRecoveryEnabled
andTopologyRecoveryEnabled
to true.After reading the RabbitMq docs, I noticed that the driver is supposed to map the old delivery tags to new delivery tags and ignore any stale delivery tags.
Is this true for .NET driver too? Or Am i missing any other configuration step?
The text was updated successfully, but these errors were encountered: