Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory usage by using the body directly instead of copying in BasicPublishAsync #1445

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Reduce memory usage by using the body directly instead of copying in BasicPublishAsync #1445

wants to merge 11 commits into from

Commits on Dec 22, 2023

  1. Reduce memory usage by using the body directly in the pipe

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    892088d View commit details
    Browse the repository at this point in the history

  2. Merge sequential memories

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    5e68abb View commit details
    Browse the repository at this point in the history

  3. Add configuration to set the copy threshold

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    ae7ca17 View commit details
    Browse the repository at this point in the history

  4. Added tests for non-copying body

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    8a59fc6 View commit details
    Browse the repository at this point in the history

  5. Fix incorrect test

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    f59728c View commit details
    Browse the repository at this point in the history

  6. Fix formatting

    @lukebakken
    lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    1f0a4be View commit details
    Browse the repository at this point in the history

  7. Re-enable test 

    This test was disabled before I've implemented TrackRentedBytesAsync correctly. This should pass now.
    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    51d6c66 View commit details
    Browse the repository at this point in the history

  8. Remove ObjectPool 

    This complicates the tests. After returning the rented object back to the pool, the data is resetted.
    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    75b8424 View commit details
    Browse the repository at this point in the history

  9. Improved disposing and fixed tests

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    70e9376 View commit details
    Browse the repository at this point in the history

  10. Fix blocking warning

    @GerardSmit @lukebakken
    GerardSmit authored and lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    1f0b20e View commit details
    Browse the repository at this point in the history

  11. Update PublicAPI.Unshipped

    @lukebakken
    lukebakken committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    7df74eb View commit details
    Browse the repository at this point in the history