New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a channel is closed, consumers should be cleaned up from AutorecoveringConnection cache #208

Closed
acogoluegnes opened this Issue Oct 21, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@acogoluegnes
Contributor

acogoluegnes commented Oct 21, 2016

This can lead to memory leaks if many consumers are created and the consumers are not cancelled. If the channel is closed, the recovery would fail anyway.

See https://groups.google.com/forum/#!topic/rabbitmq-users/d9PKyK9WXsw

@acogoluegnes acogoluegnes added this to the 3.6.x milestone Oct 21, 2016

@acogoluegnes acogoluegnes self-assigned this Oct 21, 2016

@michaelklishin michaelklishin modified the milestones: 3.6.6, 3.6.x Oct 21, 2016

@michaelklishin michaelklishin added bug and removed enhancement labels Oct 21, 2016

@michaelklishin michaelklishin changed the title from Remove channel consumers from AutorecoveringConnection when channel is closed to When a channel is closed, consumers should be cleaned up from AutorecoveringConnection cache Oct 21, 2016

acogoluegnes added a commit that referenced this issue Oct 24, 2016

acogoluegnes added a commit that referenced this issue Oct 24, 2016

Reduce method visibiliy
References #208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment