Add configurable timeout on RPC calls #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
requested changes
Dec 1, 2016
| * Exception thrown when a channel times out on a RPC call. | ||
| * @since 4.1.0 | ||
| */ | ||
| public class ChannelRpcTimeoutException extends IOException { |
Contributor
There was a problem hiding this comment.
Please rename this to ChannelContinuation…. RPC will mislead those who use higher level libraries that may claim to support "RPC".
| public static final int DEFAULT_SHUTDOWN_TIMEOUT = 10000; | ||
|
|
||
| /** The default timeout for RPC calls in channels: no timeout */ | ||
| public static final int DEFAULT_CHANNEL_RPC_TIMEOUT = -1; |
Contributor
There was a problem hiding this comment.
How about we make it, say, 10 minutes instead of infinity?
acogoluegnes
changed the title
| /** | ||
| * The channel that performed the call. | ||
| */ | ||
| private final Object channel; |
Contributor
There was a problem hiding this comment.
Should this be Channel or am I missing something?
Contributor
Author
There was a problem hiding this comment.
This exception is thrown from AMQChannel, which is not a Channel. There are several other solutions:
- having a
Channelproperty in the exception and casting theAMQChanneltoChannelwhen throwing the exception. We risk in theory aClassCastException. - having an
AMQChannelproperty in the exception, but the implementation leaks up to error handling. - having just the channel number and the connection in the exception, which should be enough to diagnose any error.
I think the third solution is a good compromise.
Contributor
There was a problem hiding this comment.
Let's add a channel number field (we can keep the field we have with a comment).
michaelklishin
approved these changes
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219