Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Rounding issue with moving averages #35

Closed
codingconcepts opened this issue Apr 8, 2015 · 10 comments
Closed

Rounding issue with moving averages #35

codingconcepts opened this issue Apr 8, 2015 · 10 comments
Assignees
Milestone

Comments

@codingconcepts
Copy link

Hi guys,

I'm sure you're already aware of this (so apologies if I'm the 1,000th person to report this):

image

The weird rounding can affect the Ready, Unacked and Total values.

Cheers,

Rob

@michaelklishin
Copy link
Member

What version do you run?

@codingconcepts
Copy link
Author

Ah yes, that'd help! I'm running 3.5.0 with Erlang 17.5. I can see that you guys have fixed a number of bugs in 3.5.1 but I can't find a release note with a list of the bugs.

Cheers Michael,

Rob

@dumbbell
Copy link
Member

dumbbell commented Apr 8, 2015

We now put the release notes on GitHub, in the rabbitmq-server project:
https://github.com/rabbitmq/rabbitmq-server/releases/tag/rabbitmq_v3_5_1

They are linked from the website as usual.

@michaelklishin
Copy link
Member

@bassrob I'm pretty sure this particular issue wasn't recently fixed. There were related things fixed for 3.5.2 but not this one.

Can you tell us a bit about your environment? What does your workload look like? Was there something suspicious in the log files around the time you've noticed this? Were there any stats DB or node failures around that time?

Thank you.

@codingconcepts
Copy link
Author

Hiya, sorry for the delay, I didn't see the notification.

I haven't been monitoring the DB but can tell you it's running up to ~900mps 24/7. Further to that, there's not much more I can offer. It's really nothing serious as we rarely need the Management Console.

Cheers,

Rob

@Gsantomaggio
Copy link
Member

To reproduce the bug you have to:

  • Select "Moving average time series" (as the image):

screen shot 2015-08-28 at 19 11 24

We're going to continue looking at this issue next week.

@michaelklishin
Copy link
Member

@Gsantomaggio good job finding a way to reproduce!

@Gsantomaggio
Copy link
Member

Thank you @michaelklishin
the problem is that function fmt_num_thousands https://github.com/rabbitmq/rabbitmq-management/blob/master/priv/www/js/formatters.js#L211 doesn't accept number with point (like this 1234.5678)

In most cases it works. We are going to fix.

@michaelklishin
Copy link
Member

@Gsantomaggio 👍

@dumbbell
Copy link
Member

dumbbell commented Sep 8, 2015

Fixed by #60.

@dumbbell dumbbell closed this as completed Sep 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants