This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Duplicate node key in GET /api/connections response
#601
Comments
michaelklishin
added a commit
to rabbitmq/rabbitmq-management-agent
that referenced
this issue
Aug 6, 2018
For proplists that represent queues the key set is fixed, so special casing 'node' should be good enough. For other entites we take a heavier handed approach and remove all duplicates from the input proplist. The overhead of this with 1K entities seems to be low single digit % in an end-to-end test that involves an HTTP client. Once we switch that code to use maps, the workaround won't be necessary at all. Closes rabbitmq/rabbitmq-management#601. [#159578855]
michaelklishin
added a commit
to rabbitmq/rabbitmq-management-agent
that referenced
this issue
Aug 6, 2018
Part of rabbitmq/rabbitmq-management#601. [#159578855]
michaelklishin
added a commit
to rabbitmq/rabbitmq-management-agent
that referenced
this issue
Aug 7, 2018
For proplists that represent queues the key set is fixed, so special casing 'node' should be good enough. For other entites we take a heavier handed approach and remove all duplicates from the input proplist. The overhead of this with 1K entities seems to be low single digit % in an end-to-end test that involves an HTTP client. Once we switch that code to use maps, the workaround won't be necessary at all. Closes rabbitmq/rabbitmq-management#601. [#159578855] (cherry picked from commit 59b0f4e)
michaelklishin
added a commit
to rabbitmq/rabbitmq-management-agent
that referenced
this issue
Aug 7, 2018
Part of rabbitmq/rabbitmq-management#601. [#159578855] (cherry picked from commit 20dc382)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
GET /api/connectionscurrently produces a duplicatenodekey.Evidence provided in this rabbitmq-users thread.
The text was updated successfully, but these errors were encountered: