Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Validate (limit) user-provided query parameters, e.g. lengths_age #97

Closed
michaelklishin opened this issue Dec 29, 2015 · 5 comments
Closed
Assignees
Milestone

Comments

@michaelklishin
Copy link
Member

lengths_age and lengths_incr need to be validated and capped the same way page size is.

@essen
Copy link
Collaborator

essen commented Jan 13, 2016

What max values should i put?

@essen
Copy link
Collaborator

essen commented Jan 13, 2016

Nevermind that. If I understand right you want to limit the number of records returned by queries that use those values, not limiting the records themselves? Ie if we request an hour of data with a sample by minutes that's 60, and perhaps we can have a hard limit of samples of 500 or something? Am I understanding right?

@michaelklishin
Copy link
Member Author

Currently it is possible to enter an arbitrarily high number and potentially put a serious strain on the management node. We need to limit our exposure to that.

@essen
Copy link
Collaborator

essen commented Jan 13, 2016

Understood, I can reproduce (even did an OOM, oops). What I was saying in the previous comment should be at least a first step.

@michaelklishin
Copy link
Member Author

Fixed in #106.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants