From cfb3f8d73ad32bbba5d7fcf920d11fe34ee8c61c Mon Sep 17 00:00:00 2001 From: wrobell Date: Sat, 22 Jun 2024 13:34:37 +0100 Subject: [PATCH] Remove Bloom filter data section for message delivery command Also update OsirisChunk entry to reflect current state. (cherry picked from commit 75278ddf21e98e3a80c273cf401e3a62770b94c6) --- deps/rabbitmq_stream/docs/PROTOCOL.adoc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/deps/rabbitmq_stream/docs/PROTOCOL.adoc b/deps/rabbitmq_stream/docs/PROTOCOL.adoc index 4aebbe2e8aae..3113ed1e4673 100644 --- a/deps/rabbitmq_stream/docs/PROTOCOL.adoc +++ b/deps/rabbitmq_stream/docs/PROTOCOL.adoc @@ -386,7 +386,7 @@ Deliver => Key Version SubscriptionId OsirisChunk Key => uint16 // 0x0008 Version => uint16 SubscriptionId => uint8 - OsirisChunk => MagicVersion NumEntries NumRecords Epoch ChunkFirstOffset ChunkCrc DataLength Messages + OsirisChunk => MagicVersion ChunkType NumEntries NumRecords Timestamp Epoch ChunkFirstOffset ChunkCrc DataLength TrailerLength BloomSize Reserved Messages MagicVersion => int8 ChunkType => int8 // 0: user, 1: tracking delta, 2: tracking snapshot NumEntries => uint16 @@ -397,9 +397,8 @@ Deliver => Key Version SubscriptionId OsirisChunk ChunkCrc => int32 DataLength => uint32 TrailerLength => uint32 - BloomSize => uint8 // size of bloom filter data + BloomSize => uint8 // size of bloom filter data, ignored at the moment Reserved => uint24 // 24 bits reserved for future use - BloomFilterData => [uint8] // bloom filter data, the size of the array is defined by BloomSize Messages => [Message] // a continous collection of messages, the size of the array is defined by NumEntries Message => EntryTypeAndSize Data => bytes @@ -413,7 +412,7 @@ Deliver => Key Version SubscriptionId CommittedOffset OsirisChunk Version => uint16 SubscriptionId => uint8 CommittedChunkId => uint64 - OsirisChunk => MagicVersion NumEntries NumRecords Epoch ChunkFirstOffset ChunkCrc DataLength Messages + OsirisChunk => MagicVersion ChunkType NumEntries NumRecords Timestamp Epoch ChunkFirstOffset ChunkCrc DataLength TrailerLength BloomSize Reserved Messages MagicVersion => int8 ChunkType => int8 // 0: user, 1: tracking delta, 2: tracking snapshot NumEntries => uint16 @@ -424,9 +423,8 @@ Deliver => Key Version SubscriptionId CommittedOffset OsirisChunk ChunkCrc => int32 DataLength => uint32 TrailerLength => uint32 - BloomSize => uint8 // size of bloom filter data + BloomSize => uint8 // size of bloom filter data, ignored at the moment Reserved => uint24 // 24 bits reserved for future use - BloomFilterData => [uint8] // bloom filter data, the size of the array is defined by BloomSize Messages => [Message] // a continous collection of messages, the size of the array is defined by NumEntries Message => EntryTypeAndSize Data => bytes