Add connection duration to "closing AMQP connection..." log messages #12215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while back, @mkuratczyk noted that we keep the timestamp of when a connection is established in the connection state and related ETS table. This PR uses the `connected_at` timestamp to calculate the duration of the connection, to make it easier to identify short-running connections via the log files.
lukebakken
force-pushed
the
add-connection-duration-to-closing-message
branch
from
e097f1f to
3440e37
Compare
It cannot contain spaces like username, virtual host and user-provided connection name can.
This reverts commit 4299e1d. It can contain spaces as it is formatted to human-readable values such as '4m, 36s'
Collaborator
|
Actually, the formatted value such as |
michaelklishin
deleted the
add-connection-duration-to-closing-message
branch
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
Sep 5, 2024
Add connection duration to "closing AMQP connection..." log messages (backport #12215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, @mkuratczyk noted that we keep the timestamp of when a connection is established in the connection state and related ETS table.
This PR uses the
connected_attimestamp to calculate the duration of the connection, to make it easier to identify short-running connections via the log files.