Skip to content

HTTP API: make GET /api/aliveness-test a no-op #13052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2025
Merged

HTTP API: make GET /api/aliveness-test a no-op #13052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 4 additions & 26 deletions deps/rabbitmq_management/src/rabbit_mgmt_wm_aliveness_test.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,37 +35,15 @@ resource_exists(ReqData, Context) ->
end, ReqData, Context}.

to_json(ReqData, Context) ->
%% This health check is deprecated and is now a no-op.
%% More specific health checks under GET /api/health/checks/* should be used instead.
%% https://www.rabbitmq.com/docs/monitoring#health-checks
rabbit_mgmt_util:with_channel(
rabbit_mgmt_util:vhost(ReqData),
ReqData,
Context,
fun(Ch) ->
#'queue.declare_ok'{queue = ?QUEUE} = amqp_channel:call(Ch, #'queue.declare'{
queue = ?QUEUE
}),
ok = amqp_channel:call(Ch, #'basic.publish'{routing_key = ?QUEUE}, #amqp_msg{
payload = <<"test_message">>
}),
case amqp_channel:call(Ch, #'basic.get'{queue = ?QUEUE, no_ack = true}) of
{#'basic.get_ok'{}, _} ->
%% Don't delete the queue. If this is pinged every few
%% seconds we don't want to create a mnesia transaction
%% each time.
rabbit_mgmt_util:reply([{status, ok}], ReqData, Context);
#'basic.get_empty'{} ->
Reason = <<"aliveness-test queue is empty">>,
failure(Reason, ReqData, Context);
Error ->
Reason = rabbit_data_coercion:to_binary(Error),
failure(Reason, ReqData, Context)
end
end
fun(_Ch) -> rabbit_mgmt_util:reply([{status, ok}], ReqData, Context) end
).

failure(Reason, ReqData0, Context0) ->
Body = #{status => failed, reason => Reason},
{Response, ReqData1, Context1} = rabbit_mgmt_util:reply(Body, ReqData0, Context0),
{stop, cowboy_req:reply(?HEALTH_CHECK_FAILURE_STATUS, #{}, Response, ReqData1), Context1}.

is_authorized(ReqData, Context) ->
rabbit_mgmt_util:is_authorized_vhost(ReqData, Context).
Loading