Stream queue: consumers are active by default (backport #13063) #13065
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, consumers using protocols other than the stream protocol would display as inactive in the Management UI/API and CLI commands, even though they were receiving messages. (cherry picked from commit 1077a55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, consumers using protocols other than the stream protocol would display as inactive in the Management UI/API and CLI commands, even though they were receiving messages.
Here's a screenshot before, with 2 stream-perf-test (one using SAC, the other not) and 1 consumer for AMQP 0.9.1, AMQP 1.0 and STOMP. You can see that only 2 consumers appear to be active, while in fact 5 were receiving messages (all except 2 non-active SAC consumers).
With this change and with the same clients running, we can indeed see 5 active consumers:
This is an automatic backport of pull request #13063 done by [Mergify](https://mergify.com).