Skip to content

cluster_minority_SUITE: Fix race in remove_node_when_seed_node_is_leader (backport #14150) #14160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

cluster_minority_SUITE: Fix race in remove_node_when_seed_node_is_leader (backport #14150) #14160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions deps/rabbit/test/cluster_minority_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,35 @@ remove_node(Config) ->
rabbit_control_helper:command(start_app, C),

%% Minority partition: A
<<<<<<< HEAD
partition_3_node_cluster(Config),
=======
partition_3_node_cluster(Config1),

Pong = ra:ping(AMember, 10000),
ct:pal("Member A state: ~0p", [Pong]),
case Pong of
{pong, leader} ->
?awaitMatch(
{ok, #{cluster_change_permitted := true}, _},
rabbit_ct_broker_helpers:rpc(Config, A, ra, member_overview, [AMember]),
60000),
?awaitMatch(
ok,
rabbit_control_helper:command(
forget_cluster_node, A, [atom_to_list(B)], []),
60000);
Ret ->
ct:pal("A is not the expected leader: ~p", [Ret]),
{skip, "Node A was not a leader"}
end.

remove_node_when_seed_node_is_follower(Config) ->
[A, B, C | _] = rabbit_ct_broker_helpers:get_node_configs(
Config, nodename),

%% Three node cluster: A, B, C
>>>>>>> 716635742 (cluster_minority_SUITE: Fix race in `remove_node_when_seed_node_is_leader`)
Cluster = [A, B, C],

ok = rabbit_control_helper:command(forget_cluster_node, A, [atom_to_list(B)], []),
Expand Down
Loading