4.3: Additional cleanup work in and around CQs #14979
Merged
+204
−2,447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the CQ state can be changed without breaking this test
all the time. Only the #msg_status{} record remains a potential
problem but thankfully it does not change often.
Requeue is handled asynchronously so this clause is unused.
The module is no longer used now that CQv1 has been removed. The only useful function remaining is `ulimit/1` which is used both in metrics and to provide a warning if too low on startup. It was moved to rabbit_runtime. The startup warning logic was moved out into rabbitmq_prelaunch. We still have some FHC related metrics that are set to 0 and are kept for compatibility reasons. Also remove unused rabbit env queue_index_max_journal_entries.
It was introduced to fix a problem in a feature that's no longer used, so we remove both the feature and code_server_cache.
Requeues are always at the head of the queue because we no longer page out messages to disk on memory pressure. The head of the queue is in memory so the code to requeue to disk is not doing anything and can be safely removed.
lhoguin
force-pushed
the
loic-cq-delivery-count
branch
from
d44ced6 to
3d2a443
Compare
lhoguin
changed the title
michaelklishin
approved these changes
Nov 25, 2025
Collaborator
|
Yay, the file handle cache is no more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch continues cleaning up CQs.
Intent in this branch WAS to add at least
delivery-countbut there was too much cleanup remaining. A future branch will implementdelivery-count.