Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 21, 2025

Proposed Changes

Add the 'apply_to' option for operator default policies.

Noticed while adding this feature, that boot step order for when quorum queues and streams register themselves to rabbit_registry is different from classic queues, and makes rabbit_registry:lookup_all(queue) not returning quorum queue and streams during boot, which is when default oper policies are applied.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.


This is an automatic backport of pull request #14976 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #14988 done by [Mergify](https://mergify.com).

SimonUnge and others added 3 commits November 21, 2025 05:08
(cherry picked from commit 9acabdb)
(cherry picked from commit accb383)

# Conflicts:
#	deps/rabbit/src/rabbit_classic_queue.erl
#	deps/rabbit/src/rabbit_quorum_queue.erl
#	deps/rabbit/src/rabbit_stream_queue.erl
(cherry picked from commit 173b0b0)
(cherry picked from commit 16b263e)
(cherry picked from commit 37b6203)
(cherry picked from commit 24fd830)
@mergify mergify bot added the conflicts label Nov 21, 2025
@mergify
Copy link
Author

mergify bot commented Nov 21, 2025

Cherry-pick of accb383 has failed:

On branch mergify/bp/v4.1.x/pr-14988
Your branch is up to date with 'origin/v4.1.x'.

You are currently cherry-picking commit accb38351.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   deps/rabbit/priv/schema/rabbit.schema
	modified:   deps/rabbit/src/rabbit_db_vhost_defaults.erl
	modified:   deps/rabbit/test/config_schema_SUITE_data/rabbit.snippets

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbit/src/rabbit_classic_queue.erl
	both modified:   deps/rabbit/src/rabbit_quorum_queue.erl
	both modified:   deps/rabbit/src/rabbit_stream_queue.erl

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@michaelklishin michaelklishin modified the milestone: 4.1.7 Nov 21, 2025
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-14988 branch November 21, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants