Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retries to AWS API calls #3329

Closed
wants to merge 3 commits into from
Closed

Adding retries to AWS API calls #3329

wants to merge 3 commits into from

Conversation

@biacar
Copy link
Contributor

@biacar biacar commented Aug 19, 2021

Proposed Changes

This PR addresses the issues related to transient errors while querying AWS APIs. Retries have been added to AWS API calls with a sleep time in between the calls to make sure whatever the error code returned by AWS is not transient. Credential errors are not retried.

The motivation behind this PR is unlock failures during peer discovery due to timed out AWS calls. The retries on the AWS calls would reduce the possibility of a node not releasing the discovery lock after successfully joining a cluster.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • [ x ] I have read the CONTRIBUTING.md document
  • [ x ] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • [ x ] All tests pass locally with my changes
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] I have added necessary documentation (if appropriate)
  • [ x ] Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

Adding retries to AWS API calls
@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Aug 20, 2021

Merged manually.

@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Aug 20, 2021

Backported to v3.9.x.

@michaelklishin michaelklishin added this to the 3.9.5 milestone Aug 20, 2021
@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Aug 20, 2021

Two cosmetic follow-up PRs: 59ebb83, 6bf4a99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants