Skip to content

/ rabbitmq-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly import virtual host metadata #3333

Merged
merged 2 commits into from Aug 24, 2021
Merged

Correctly import virtual host metadata #3333

merged 2 commits into from Aug 24, 2021

Conversation

@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Aug 24, 2021

Proposed Changes

With this change virtual hosts with metadata are imported correctly (tags and description are not lost).

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories
@michaelklishin
Definition import: correctly import vhost metadata
6f97707
@michaelklishin
Commit definition import case16 file
2e61f51
@michaelklishin michaelklishin changed the title Mk definition import of vhost with metadata Correctly import virtual host metadata Aug 24, 2021
@michaelklishin michaelklishin added this to the 3.8.22 milestone Aug 24, 2021
@michaelklishin michaelklishin merged commit a809e55 into master Aug 24, 2021
8 checks passed
8 checks passed
@github-actions
build-publish-dev (23.2) build-publish-dev (23.2)
Details
@github-actions
Test (23)
Details
@github-actions
build-publish-dev (24.0.4) build-publish-dev (24.0.4)
Details
@github-actions
Test (24)
Details
@github-actions
Test (Exclusive Tests) (23) Test (Exclusive Tests) (23)
Details
@github-actions
Test (Exclusive Tests) (24) Test (Exclusive Tests) (24)
Details
@mergify
Summary 2 potential rules
Details
bazel test //... Success in 17m
Details
@michaelklishin michaelklishin deleted the mk-definition-import-of-vhost-with-metadata branch Aug 24, 2021
@michaelklishin
Copy link
Member Author

@michaelklishin michaelklishin commented Aug 24, 2021

@Mergifyio backport v3.9.x v3.8.x

This was referenced Aug 24, 2021
Merged
Closed
@mergify
Copy link

@mergify mergify bot commented Aug 24, 2021

Command backport v3.9.x v3.8.x: success

Backports have been created

michaelklishin added a commit that referenced this pull request Aug 24, 2021
@michaelklishin
Merge pull request #3333 from rabbitmq/mk-definition-import-of-vhost-…
15ba136 
…with-metadata

Correctly import virtual host metadata

(cherry picked from commit a809e55)
michaelklishin added a commit that referenced this pull request Aug 24, 2021
@michaelklishin
Merge pull request #3334 from rabbitmq/mergify/bp/v3.9.x/pr-3333
7063629 
Correctly import virtual host metadata (backport #3333)
@michaelklishin
Copy link
Member Author

@michaelklishin michaelklishin commented Aug 24, 2021

Backported to v3.8.x.

michaelklishin added a commit that referenced this pull request Aug 26, 2021
@michaelklishin
Exclude the #3333 test case from mixed version runs
42a3dfa
michaelklishin added a commit that referenced this pull request Aug 26, 2021
@michaelklishin
Exclude the #3333 test case from mixed version runs
5876784 
(cherry picked from commit 42a3dfa)
michaelklishin added a commit that referenced this pull request Aug 26, 2021
@michaelklishin
Exclude the #3333 test case from mixed version runs
b76fbc3 
(cherry picked from commit 42a3dfa)
michaelklishin added a commit that referenced this pull request Aug 26, 2021
@michaelklishin
Exclude roundtrip definition import cases from mixed version runs
3b4b4dc 
References #3333
michaelklishin added a commit that referenced this pull request Aug 26, 2021
@michaelklishin
Exclude roundtrip definition import cases from mixed version runs
7f271ae 
References #3333

(cherry picked from commit 3b4b4dc)
michaelklishin added a commit that referenced this pull request Aug 26, 2021
@michaelklishin
Exclude roundtrip definition import cases from mixed version runs
fd05769 
References #3333

(cherry picked from commit 3b4b4dc)
michaelklishin added a commit that referenced this pull request Aug 28, 2021
@michaelklishin
Revert "Exclude the #3333 test case from mixed version runs"
a4a7c53 
This reverts commit 5876784.
michaelklishin added a commit that referenced this pull request Aug 28, 2021
@michaelklishin
Revert "Merge pull request #3333 from rabbitmq/mk-definition-import-o…
5e561da 
…f-vhost-with-metadata"

This reverts commit 15ba136.
@michaelklishin michaelklishin modified the milestones: 3.8.22, 3.9.5 Aug 28, 2021
michaelklishin added a commit that referenced this pull request Aug 28, 2021
@michaelklishin
Revert "Revert "Merge pull request #3333 from rabbitmq/mk-definition-…
632ca76 
…import-of-vhost-with-metadata""

This reverts commit 5e561da.
michaelklishin added a commit that referenced this pull request Aug 28, 2021
@michaelklishin
Revert "Revert "Exclude the #3333 test case from mixed version runs""
656c3bd 
This reverts commit a4a7c53.
@michaelklishin michaelklishin modified the milestones: 3.9.5, 3.8.22 Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.22
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@michaelklishin