New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang] Do not panic after log.Fatalf #597

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@lyrixx
Contributor

lyrixx commented Oct 5, 2018

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster Oct 5, 2018

@lyrixx Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented Oct 5, 2018

@lyrixx Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster commented Oct 5, 2018

@lyrixx Thank you for signing the Contributor License Agreement!

@michaelklishin michaelklishin merged commit ec4d3c7 into rabbitmq:live Oct 5, 2018

1 check passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Oct 5, 2018

Member

Thank you! May I ask you to take a look at whether the runnable version might need similar changes?

Member

michaelklishin commented Oct 5, 2018

Thank you! May I ask you to take a look at whether the runnable version might need similar changes?

@lyrixx lyrixx deleted the lyrixx:fix-goland branch Oct 5, 2018

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Oct 5, 2018

Contributor

@michaelklishin Sure. I had a look and the code is good there. Thanks for merging.

Contributor

lyrixx commented Oct 5, 2018

@michaelklishin Sure. I had a look and the code is good there. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment